Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emacs): set font for all frames, not just for new ones #656

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(emacs): set font for all frames, not just for new ones #656

merged 1 commit into from
Dec 10, 2024
+1 −1

Conversation

thecaralice
Copy link
Contributor

I have not checked extensively, but the existing solution did not work for me on macOS for some unknown reason.

@trueNAHO
Copy link
Collaborator

trueNAHO commented Dec 1, 2024

@jezcope, can you approve this?

danth
danth approved these changes Dec 10, 2024
View reviewed changes
Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but it makes perfect sense based on the documentation.

trueNAHO
trueNAHO approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but it makes perfect sense based on the documentation.

Let's just get this merged then.

@trueNAHO trueNAHO merged commit bc25f3d into danth:master Dec 10, 2024
12 checks passed
@stylix-automation
Copy link

Successfully created backport PR for release-24.11:

stylix-automation bot pushed a commit that referenced this pull request Dec 10, 2024
@thecaralice @github-actions
emacs: set font for all frames, not just for new ones (#656)
d1a5305 
The existing solution does not work on macOS for some reason.

Reviewed-by: Daniel Thwaites <[email protected]>
Reviewed-by: NAHO <[email protected]>
(cherry picked from commit bc25f3d)
@stylix-automation stylix-automation bot mentioned this pull request Dec 10, 2024
Merged
trueNAHO pushed a commit that referenced this pull request Dec 10, 2024
@thecaralice @trueNAHO
emacs: set font for all frames, not just for new ones (#656)
072a313 
The existing solution does not work on macOS for some reason.

Reviewed-by: Daniel Thwaites <[email protected]>
Reviewed-by: NAHO <[email protected]>
(cherry picked from commit bc25f3d)
@thecaralice thecaralice deleted the emacs-font branch December 10, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueNAHO trueNAHO trueNAHO approved these changes

@danth danth danth approved these changes

Assignees
No one assigned
Labels
backport release-24.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thecaralice @trueNAHO @danth